This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor(): delete a usless conditional sentence #14282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete a conditional sentences. it is marked with a TODO tag to be deleted.
| @@ -348,8 +348,6 @@ var $$AnimationProvider = ['$animateProvider', function($animateProvider) { | |||
| // may attempt more elements, but custom drivers are more particular | |||
| for (var i = drivers.length - 1; i >= 0; i--) { | |||
| var driverName = drivers[i]; | |||
| if (!$injector.has(driverName)) continue; // TODO(matsko): remove this check | |||
There was a problem hiding this comment.
@matsko, any idea why you had marked this for removal ?
There was a problem hiding this comment.
Pretty sure this was only here for debugging. If the driverName refers to a driver that has not be registered with the injector then that is surely an error.
We register only two drivers in the ngAnimate module:
$$animateCssDriver$$animateJsDriver
We do this from inside their respective providers, so it is not possible for our code to break this.
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 10, 2016
Delete a conditional statement that appears to have only been for debugging. It is marked with a TODO tag to be deleted. Closes #14282
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
refactor
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
the same
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information:
delete a conditional sentences. it is marked with a TODO tag to be deleted.